Fix Options types by making them writable #1204
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried integrating the API in semantic-release-vsce but found that the Options interfaces are too restrictive.
They don't allow things like:
Which fails with:
So, after thinking about it, I believe the best solution is to remove the
readonlymodifier from all properties of Options interfaces. I don't think they serve any purpose, except making the API harder to use in real-world scenarios.What do you think?