Debugger: Put "Run To Cursor" Into Breakpoint Context Menu

[hediet]

Currently, "Run To Cursor" is in a very long context menu:

I think it would make sense to add "Run To Cursor" to the context menu for adding breakpoints:

This new entry should be called "Run To Line".

Pro:

• That context menu is already strictly debugging related
• If a user does not know about "Run To Cursor" and manually places a breakpoint to the target location, they might discover this functionality in that context menu

Contra:

• "Run To Line" is not a breakpoint

[isidorn]

@hediet thanks for this suggestion, however please note that we show the Run To Cursor and Add Inline Breakpoint in the editor context menu only while a user is debugging. So it is not always there.

I understand you are always in debugging mode and I think we should improve the experience for "Always Debugging" mode. For this I have created #123873

For now I would probably not change this to not anger some users that are used to it. Especially since I hope we will have customisable context menus in the future. However I am open for ideas.

fyi @connor4312 @weinand

[hediet]

however please note that we show the Run To Cursor and Add Inline Breakpoint in the editor context menu only while a user is debugging. So it is not always there.

I wouldn't neccessarily remove it from the editor context menu, but just add it to the breakpoint context menu to improve its accessibility. My idea is not to shorten the editor context menu, but to make that feature easier to use.

I use that feature quite often (and should probably assign a keybinding to it), but the very long context menu makes it hard to quickly execute that action (especially when my focus is on debugging the problem, not finding that context menu entry).

The Chrome dev tools have an even more efficient approach - while debugging, you can simply Ctrl-Click on a statement to continue to it. That does not play very well with VS Codes "Go To Definition" though.

[isidorn]

@hediet oh you would simply add it to the other context menu.
Yeah this could work for me.

Let's see what @connor4312 and @weinand think

[connor4312]

Adding it to the breakpoint (gutter) context menu sounds good to me. Honestly I didn't even know that context menu entry existed, I never right click in the editor 😛

[isidorn]

If we were to add it, I would put a separator after the breakpoint actions. And have the "Run to Line" at the bottom.
Let's assign to this milestone and if Andre does not object I can add it next week.

[hediet]

I can also try to implement it if we go for it! Shouldn't be that hard.

[connor4312]

Code pointer:

vscode/src/vs/workbench/contrib/debug/browser/breakpointEditorContribution.ts

Line 317 in 1ccd6a0

private getContextMenuActions(breakpoints: ReadonlyArray<IBreakpoint>, uri: URI, lineNumber: number, column?: number): IAction[] {

[hediet]

Do you think the logic in RunToCursorAction should be moved to IDebugService and its implementation (and there renamed to RunToPosition)?
Then there could be both a RunToCursorAction and RunToLineAction.

[isidorn]

@hediet that might work. However I try to keep the IDebugService as thin as possible. So I would personally just use the commandService.executeCommand to execute one command from the other.
Though feel free to move the logic to the IDebugService if you prefer that

[isidorn]

Leaving this assigned to you @hediet as you plan to do a PR.
Feel free to ping me on a PR for a review or let me know if I can help in any way.