Skip to content

Fix some nullability warnings in tests #4452

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 15, 2023
Merged

Fix some nullability warnings in tests #4452

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/Microsoft.TestPlatform.CommunicationUtilities.Platform.UnitTests/SocketClientTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public void SocketClientStartShouldThrowIfServerIsNotListening()
[TestMethod]
public void SocketClientStopShouldRaiseClientDisconnectedEventOnClientDisconnection()
{
var waitEvent = SetupClientDisconnect(out ICommunicationChannel _);
var waitEvent = SetupClientDisconnect(out ICommunicationChannel? _);

// Close the communication from client side
_socketClient.Stop();
Expand All @@ -94,7 +94,7 @@ public void SocketClientStopShouldRaiseClientDisconnectedEventOnClientDisconnect
[TestMethod]
public void SocketClientShouldRaiseClientDisconnectedEventIfConnectionIsBroken()
{
var waitEvent = SetupClientDisconnect(out ICommunicationChannel _);
var waitEvent = SetupClientDisconnect(out ICommunicationChannel? _);

// Close the communication from server side
_tcpClient?.GetStream().Dispose();
Expand All @@ -106,7 +106,7 @@ public void SocketClientShouldRaiseClientDisconnectedEventIfConnectionIsBroken()
[TestMethod]
public void SocketClientStopShouldStopCommunication()
{
var waitEvent = SetupClientDisconnect(out ICommunicationChannel _);
var waitEvent = SetupClientDisconnect(out ICommunicationChannel? _);

// Close the communication from socket client side
_socketClient.Stop();
Expand Down Expand Up @@ -157,7 +157,7 @@ private ManualResetEvent SetupClientDisconnect(out ICommunicationChannel? channe
{
var waitEvent = new ManualResetEvent(false);
_socketClient.Disconnected += (s, e) => waitEvent.Set();
channel = SetupChannel(out ConnectedEventArgs _);
channel = SetupChannel(out ConnectedEventArgs? _);
channel!.MessageReceived += (sender, args) =>
{
};
Expand Down
2 changes: 1 addition & 1 deletion test/Microsoft.TestPlatform.CommunicationUtilities.Platform.UnitTests/SocketServerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ public void SocketServerShouldRaiseClientDisconnectedEventIfConnectionIsBroken()
[TestMethod]
public async Task SocketEndpointShouldInitializeChannelOnServerConnection()
{
var channel = SetupChannel(out ConnectedEventArgs _);
var channel = SetupChannel(out ConnectedEventArgs? _);

await channel!.Send(Dummydata);

Expand Down