Skip to content

fix Atribute typo #5057

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024
Merged

fix Atribute typo #5057

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/Microsoft.TestPlatform.Acceptance.IntegrationTests/LoggerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ public void HtmlLoggerWithFriendlyNameContainsExpectedContent(RunnerInfo runnerI
private static XmlDocument LoadReport(string htmlLogFilePath)
{
// XML reader cannot handle <br> tags because they are not closed, and hence are not valid XML.
// They are correct HTML though, so we patch it here.
// They are correct HTML though, so we patch it here.
var text = File.ReadAllText(htmlLogFilePath).Replace("<br>", "<br/>");
var report = new XmlDocument();
report.Load(new StringReader(text));
Expand Down Expand Up @@ -163,7 +163,7 @@ public void TrxLoggerResultSummaryOutcomeValueShouldBeFailedIfNoTestsExecutedAnd

InvokeVsTest(arguments);

string? outcomeValue = GetElementAtributeValueFromTrx(trxFilePath, "ResultSummary", "outcome");
string? outcomeValue = GetElementAttributeValueFromTrx(trxFilePath, "ResultSummary", "outcome");

Assert.AreEqual("Failed", outcomeValue);
}
Expand All @@ -186,7 +186,7 @@ public void TrxLoggerResultSummaryOutcomeValueShouldNotChangeIfNoTestsExecutedAn

InvokeVsTest(arguments);

string? outcomeValue = GetElementAtributeValueFromTrx(trxFilePath, "ResultSummary", "outcome");
string? outcomeValue = GetElementAttributeValueFromTrx(trxFilePath, "ResultSummary", "outcome");

Assert.AreEqual("Completed", outcomeValue);
}
Expand Down Expand Up @@ -240,7 +240,7 @@ private static void IsFileAndContentEqual(string filePath)
}
}

private static string? GetElementAtributeValueFromTrx(string trxFileName, string fieldName, string attributeName)
private static string? GetElementAttributeValueFromTrx(string trxFileName, string fieldName, string attributeName)
{
using FileStream file = File.OpenRead(trxFileName);
using XmlReader reader = XmlReader.Create(file);
Expand Down