Skip to content

remove unnecessary list alloc for 2 scenarios in TestRequestManager.GetSources #5058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2024
Merged

remove unnecessary list alloc for 2 scenarios in TestRequestManager.GetSources #5058

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions src/vstest.console/TestPlatformHelpers/TestRequestManager.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1510,23 +1510,21 @@ private IRequestData GetRequestData(ProtocolConfig protocolConfig)
private static List<string> GetSources(TestRunRequestPayload testRunRequestPayload)
{
// TODO: This should also use hashset to only return distinct sources.
List<string> sources = new();
if (testRunRequestPayload.Sources != null
&& testRunRequestPayload.Sources.Count > 0)
if (testRunRequestPayload.Sources is { Count: > 0 })
{
sources = testRunRequestPayload.Sources;
return testRunRequestPayload.Sources;
}
else if (testRunRequestPayload.TestCases != null
&& testRunRequestPayload.TestCases.Count > 0)

if (testRunRequestPayload.TestCases is { Count: > 0 })
{
ISet<string> sourcesSet = new HashSet<string>();
var sourcesSet = new HashSet<string>();
foreach (var testCase in testRunRequestPayload.TestCases)
{
sourcesSet.Add(testCase.Source);
}
sources = sourcesSet.ToList();
return sourcesSet.ToList();
}
return sources;
return [];
}
}

Expand Down