Dispose XmlReader in XmlRunSettingsUtilities #5094
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing code disposes the underlying stream, but not the XmlReader itself, even though the XmlReader is an IDisposable too.
This was referenced Nov 20, 2024
This was referenced Jul 22, 2025
Merged
This was referenced Oct 29, 2025
Closed
Bump Microsoft.NET.Test.Sdk from 16.9.4 to 17.13.0
zzulueta/skills-secure-repository-supply-chain#10
Open
Bump Microsoft.NET.Test.Sdk from 16.9.4 to 17.13.0
kossirra/skills-secure-repository-supply-chain#10
Open
Open
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The existing code disposes the underlying stream, but not the XmlReader itself, even though the XmlReader is an IDisposable too.
Related issue
Fixes: #5093