Optimize error propagation #2819
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
windows-corecrate provides rich error propagation for Windows via the standardResulttype and a Windows-specificErrortype that supports a variety of Windows-specific error reporting and propagation APIs that have been used over the years. Originally it was tailored for WinRT, but with this update it is now optimized for the fastest possible call paths to reduce the overhead even in the case of error propagation. It is now also a lot more careful to avoid redundantly storing and retrieving error information, eliminating a lot of unnecessary execution and copies. Whether you're interested only in Win32, COM, or WinRT APIs it will give you the best possible performance and the most accurate error information available for the given API technology.