Simpler code generation #3370
Merged
Simpler code generation #3370
+6
−55,289
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #3359 I mostly went for code gen parity (for validation) but with an eye toward greatly simplifying the resulting code gen once the new generator was available. Here are the first two of those simplifications:
Remove the "return void" hint to simplify the various Win32 style method permutations. I'd like to simplify this further but this is a good start.
Remove the
TypeKindimplementation on all Win32 structs. It really should only be needed for some WinRT types. I'd like to remove them on Win32 handles as well but that will require a bit more work so I'll handle that separately. 🙂And this is why: