Skip to content

Fix provenance in direct32 sample #3419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2025
Merged

Fix provenance in direct32 sample #3419

merged 1 commit into from
Jan 7, 2025

Conversation

@ChrisDenton
Copy link
Collaborator

@ChrisDenton ChrisDenton commented Jan 6, 2025 •
edited
Loading

Using transmute creates a pointer without provenance. Using an as cast instead fixes this.

Fixes: #3406

@ChrisDenton
Fix provenance in direct32 sample
f07d80c 
Using transmute creates a pointer without provenance. Using an `as` cast instead fixes this.
@ChrisDenton ChrisDenton mentioned this pull request Jan 6, 2025
Closed
@ChrisDenton
Copy link
Collaborator Author

Note: Ideally we'd use ptr::with_exposed_provenance to make it more explicit but that won't stabilize until 1.84.

kennykerr
kennykerr approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@kennykerr kennykerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kennykerr kennykerr merged commit 3566fca into microsoft:master Jan 7, 2025
75 checks passed
@kennykerr kennykerr mentioned this pull request Jan 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kennykerr kennykerr kennykerr approved these changes

+1 more reviewer

@damyanp damyanp damyanp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Direct3D12 sample doesn't render properly in release builds

3 participants

@ChrisDenton @damyanp @kennykerr