Explicitly schedule coroutines as Tasks #281
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing coroutine objects to wait() directly is deprecated since Python version 3.8 and will be removed in version 3.11: https://docs.python.org/3/library/asyncio-task.html#asyncio.wait This change eliminates the following DeprecationWarning: tests/asyncio/test_asyncio_server.py::TestAsyncServer::test_disconnect_all /builddir/build/BUILDROOT/python-engineio-4.3.2-1.fc37.x86_64/usr/lib/python3.10/site-packages/engineio/asyncio_server.py:178: DeprecationWarning: The explicit passing of coroutine objects to asyncio.wait() is deprecated since Python 3.8, and scheduled for removal in Python 3.11. await asyncio.wait([client.close() on Python 3.8–3.10, and it fixes failure of: tests/asyncio/test_asyncio_server.py::TestAsyncServer::test_disconnect_all on Python 3.11.0b3 (pre-release). This change is a partial fix for miguelgrinberg#279.
Owner
|
Thank you so much! |
Contributor
Author
|
You’re welcome! Thank you for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing coroutine objects to
wait()directly is deprecated since Python version 3.8 and will be removed in version 3.11:https://docs.python.org/3/library/asyncio-task.html#asyncio.wait
This change eliminates the following
DeprecationWarning:on Python 3.8–3.10, and it fixes failure of:
on Python 3.11.0b3 (pre-release).
This change is a partial fix for #279.
The implementation is based on the example in the Python documentation.