Skip to content

Update admin IDP commands with new design #4310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 3, 2022
Merged

Update admin IDP commands with new design #4310

merged 2 commits into from
Nov 3, 2022

Conversation

@donatello
Copy link
Member

@donatello donatello commented Oct 19, 2022 •
edited
Loading

Description

This change adds new commands:

# mc admin idp openid add|remove|update|list|info|enable|disable
# mc admin idp ldap add|remove|update|list|info|enable|disable

and hides the following with a deprecation notice in the help:

# mc admin idp set|info|ls|rm

Motivation and Context

Make it easier to configure and manage external IDPs.

How to test this PR?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

@donatello donatello mentioned this pull request Oct 19, 2022
Merged
8 tasks
@donatello donatello force-pushed the rename-idp-openid branch 6 times, most recently from df3afc2 to 19c136b Compare October 19, 2022 18:23
@donatello donatello changed the title WIP: Update admin IDP commands with new design Update admin IDP commands with new design Oct 19, 2022
@donatello donatello marked this pull request as ready for review October 19, 2022 18:24
@donatello donatello mentioned this pull request Oct 20, 2022
Merged
8 tasks
@donatello donatello force-pushed the rename-idp-openid branch 2 times, most recently from ef35bf4 to f8dbd10 Compare October 31, 2022 18:24
@donatello donatello requested review from krisis and vadmeste October 31, 2022 18:45
@donatello
Add new commands for openid and ldap configuration
6adf13f 
This change also hides the following commands and adds a deprecation
notice:

mc admin idp set|ls|rm|info
@donatello
Copy link
Member Author

donatello commented Nov 2, 2022

This is ready PTAL @harshavardhana @krisis @vadmeste @kannappanr

@harshavardhana harshavardhana merged commit 583d449 into minio:master Nov 3, 2022
@donatello donatello deleted the rename-idp-openid branch November 3, 2022 01:53
@djwfyi djwfyi mentioned this pull request Nov 8, 2022
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@krisis krisis krisis approved these changes

@harshavardhana harshavardhana harshavardhana approved these changes

@kannappanr kannappanr Awaiting requested review from kannappanr

@vadmeste vadmeste Awaiting requested review from vadmeste

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@donatello @krisis @harshavardhana