Skip to content

move to simple-xml-safe #908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 27, 2020
Merged

move to simple-xml-safe #908

merged 1 commit into from
Apr 27, 2020

Conversation

@balamurugana
Copy link
Member

Fixes #905

harshavardhana
harshavardhana previously approved these changes Apr 15, 2020
View reviewed changes
Copy link
Member

@harshavardhana harshavardhana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, does this break any existing releases? @balamurugana

@balamurugana
Copy link
Member Author

LGTM, does this break any existing releases? @balamurugana

No. simple-xml-safe matches with same signature of simple-xml

kannappanr
kannappanr previously approved these changes Apr 16, 2020
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@balamurugana balamurugana dismissed stale reviews from kannappanr and harshavardhana via ad0612c April 21, 2020 14:24
@balamurugana balamurugana force-pushed the move-to-simple-xml-safe branch from 027d271 to ad0612c Compare April 21, 2020 14:24
kannappanr
kannappanr approved these changes Apr 25, 2020
View reviewed changes
Copy link
Contributor

@kannappanr kannappanr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kannappanr
Copy link
Contributor

ping @harshavardhana

@kannappanr kannappanr merged commit 428e93d into minio:master Apr 27, 2020
@balamurugana balamurugana deleted the move-to-simple-xml-safe branch April 27, 2020 11:18
@harshavardhana harshavardhana mentioned this pull request Jun 15, 2020
Closed
harshavardhana pushed a commit that referenced this pull request Jun 15, 2020
@balamurugana @minio-trusted
move to simple-xml-safe (#908)
9f040d5 
Fixes #905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@kannappanr kannappanr kannappanr approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CVE-2017-1000190

3 participants

@balamurugana @kannappanr @harshavardhana