Fix: Add missing type annotations to serialization dataclass fields #1527
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: minio/mint#399.
Problem
PR #1504 (v7.2.17) converted serialization classes to dataclasses but did not add type annotations to fields. Without type annotations, they don't become
__init__parameters.Error:
Root Cause
# Broken (v7.2.17+):
# Fixed:
# Solution:
Add
Optional[str]type annotations to all dataclass fields in:CSVInputSerialization(7 fields)JSONInputSerialization(1 field)CSVOutputSerialization(5 fields)JSONOutputSerialization(1 field)