Adding volumes page to tenants #1019
Conversation
adfost
force-pushed
the
accessrulebugfix
branch
3 times, most recently
from
149f5fd to
67c4c3f
Compare
| width: 120, | ||
| }, | ||
| { | ||
| label: "Tenant", |
There was a problem hiding this comment.
This column is redundant, please remove it
swagger-operator.yml
Outdated
| tags: | ||
| - OperatorAPI | ||
|
|
||
| /namespaces/{namespace}/tenants/{tenant}/list-pvcs: |
There was a problem hiding this comment.
the verb GET implies listing, and this endpoint is about the pvc resource, can you rename it to /namespaces/{namespace}/tenants/{tenant}/pvcs
operatorapi/operator_volumes.go
Outdated
| } | ||
|
|
||
| // List all PVCs | ||
| listAllPvcs, err2 := clientset.CoreV1().PersistentVolumeClaims("").List(ctx, listOpts) |
There was a problem hiding this comment.
you can actually filter by namespace here
| { | ||
| type: "view", | ||
| onClick: (record: any) => { | ||
| history.push( | ||
| `/namespaces/${record.namespace}/tenants/${record.tenant}` | ||
| ); | ||
| }, | ||
| }, |
There was a problem hiding this comment.
Not sure if this action is needed as you are in the tenant and it only redirects you to summary page
There was a problem hiding this comment.
+1 this action doesn't make sense for this listing, let's remove it
dvaldivia
left a comment
dvaldivia
left a comment
There was a problem hiding this comment.
Make sure you are on prettier 2.3.2
prettier --version
2.3.2
and format your files.
| { | ||
| type: "view", | ||
| onClick: (record: any) => { | ||
| history.push( | ||
| `/namespaces/${record.namespace}/tenants/${record.tenant}` | ||
| ); | ||
| }, | ||
| }, |
There was a problem hiding this comment.
+1 this action doesn't make sense for this listing, let's remove it
adfost
force-pushed
the
accessrulebugfix
branch
from
973f454 to
b0fa0ef
Compare
adfost
force-pushed
the
accessrulebugfix
branch
from
b0fa0ef to
3834f99
Compare
3 participants
Adds a page showing volumes for a tenant.