List buckets re-design #1058
Merged
List buckets re-design #1058
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
requested review from
Alevsk,
adfost,
bexsoft,
harshavardhana and
jinapurapu
adfost
previously approved these changes
Sep 18, 2021
Signed-off-by: Daniel Valdivia <[email protected]>
dvaldivia
force-pushed
the
list-buckets-redesin
branch
from
7c16c61 to
1336af4
Compare
adfost
previously approved these changes
Sep 18, 2021
bexsoft
requested changes
Sep 20, 2021
Collaborator
bexsoft
left a comment
bexsoft
left a comment
There was a problem hiding this comment.
Please review TextField component usage under ListBuckets
portal-ui/src/screens/Console/Buckets/ListBuckets/ListBuckets.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Daniel Valdivia <[email protected]>
Signed-off-by: Daniel Valdivia <[email protected]>
Signed-off-by: Daniel Valdivia <[email protected]>
Signed-off-by: Daniel Valdivia <[email protected]>
bexsoft
approved these changes
Sep 20, 2021
Collaborator
bexsoft
left a comment
bexsoft
left a comment
There was a problem hiding this comment.
LGTM, Need to delete node_modules & make yarn install again to run this.
Alevsk
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Reactive design.
To Test this change you must use MinIO Master