Return parseable error on S3 requests #1120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return S3 compatible error when an S3 API request is made to the console port. Before: ``` λ mc ls local9090 mc: <ERROR> Unable to list folder. XML syntax error on line 1: invalid character entity &display (no semicolon) ``` After: ``` λ mc ls local9090 mc: <ERROR> Unable to list folder. S3 API Request made to Console port. S3 Requests should be sent to MinIO API port. ```
klauspost
force-pushed
the
reject-s3-requests
branch
from
4470a47 to
d185851
Compare
harshavardhana
requested changes
Oct 19, 2021
dvaldivia
approved these changes
Oct 19, 2021
Alevsk
approved these changes
Oct 19, 2021
harshavardhana
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a huge amount of support questions where users are using the console port instead of the API port.
Return S3 compatible error when an S3 API request is made to the console port.
Before:
After: