Securizing bucket tags #1249
Merged
Securizing bucket tags #1249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfost
requested review from
Alevsk,
bexsoft,
dvaldivia,
jinapurapu and
prakashsvmx
Alevsk
reviewed
Nov 22, 2021
portal-ui/src/screens/Console/Buckets/BucketDetails/BucketSummaryPanel.tsx
Outdated
Show resolved
Hide resolved
bexsoft
requested changes
Nov 23, 2021
Collaborator
bexsoft
left a comment
bexsoft
left a comment
There was a problem hiding this comment.
Would you please help us to remove this warning?
Beside of that comment, LGTM
portal-ui/src/screens/Console/Buckets/BucketDetails/BucketSummaryPanel.tsx
Outdated
Show resolved
Hide resolved
portal-ui/src/screens/Console/Buckets/BucketDetails/BucketSummaryPanel.tsx
Show resolved
Hide resolved
adfost
force-pushed
the
securize_bucket_tags
branch
from
3b85aa2 to
2442c8e
Compare
prakashsvmx
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bucket tags and/or edit/delete bucket tags disappear when user does not have those permissions.