Application routing now uses SecureComponent and hasPermission function #1288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Alevsk
force-pushed
the
refactor-console-endpoints
branch
3 times, most recently
from
d905286 to
7345681
Compare
Alevsk
requested review from
adfost,
bexsoft,
dvaldivia,
harshavardhana,
jinapurapu and
prakashsvmx
Alevsk
changed the title
Alevsk
force-pushed
the
refactor-console-endpoints
branch
2 times, most recently
from
89c1ca3 to
128daff
Compare
Alevsk
changed the title
Alevsk
force-pushed
the
refactor-console-endpoints
branch
3 times, most recently
from
dd48932 to
a1f14c0
Compare
Alevsk
changed the title
Alevsk
force-pushed
the
refactor-console-endpoints
branch
4 times, most recently
from
27b131f to
c1fbb01
Compare
Alevsk
changed the title
- Some menu options were not showing even if the user has access to perform the operations (IAM Policies) - Deleted unecessary backend endpoints.go logic, instead using SecureComponent to validate application routes and Menu options rendering - All the logic related to routes and permissions is now in the permissions.ts file - Added SecureComponent to List Users page - Separated Menu options and routing logic for AdminConsole and OperatorConsole - Tools are hidden if user don't have access to them or MinIO is running in fs mode (heal, audit log, etc - Hide change-password button if user don't have access - Hide create user button if user don't have access - fixed some bugs when ldap/oidc is enabled Signed-off-by: Lenin Alevski <[email protected]>
Alevsk
force-pushed
the
refactor-console-endpoints
branch
from
c1fbb01 to
892c923
Compare
Alevsk
changed the title
dvaldivia
approved these changes
Dec 14, 2021
harshavardhana
approved these changes
Dec 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perform the operations (IAM Policies)
SecureComponent to validate application routes and Menu options
rendering
permissions.ts file
OperatorConsole
in fs mode (heal, audit log, etc