Fixed share/download object regression #1296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lenin Alevski <[email protected]>
Alevsk
requested review from
adfost,
bexsoft,
dvaldivia,
harshavardhana and
jinapurapu
harshavardhana
previously approved these changes
Dec 6, 2021
Signed-off-by: Lenin Alevski <[email protected]>
harshavardhana
approved these changes
Dec 6, 2021
bexsoft
approved these changes
Dec 6, 2021
Collaborator
bexsoft
left a comment
bexsoft
left a comment
There was a problem hiding this comment.
Empty bytes issue is fixed. Still missing the issue with file names, this PR passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's one new issue this bug fix exposed which is downloading objects with Chinese characters goes from:
小飼弾小飼弾小飼弾.jpg->å°_飼弾å°_飼弾å°_飼弾.jpegI'll address this on the next PR
Test
Please test by uploading an object with name
小飼弾小飼弾小飼弾.jpg, then:Signed-off-by: Lenin Alevski [email protected]