Download Chinese filenames bug fix

[adfost]

Fixes a bug where Chinese filenames would be messed up when being downloaded.

Fixes https://github.com/minio/console/issues/1351

[jinapurapu]

"+" being appended to end of filenames on download

[jinapurapu]

Filenames being garbled if they contain "+", regardless of Chinese characters

[prakashsvmx]

Minor comment.

otherwise
Tested. Changes look good to me. 👍

[harshavardhana]

Strange unrelated test failure

=== RUN   TestGetLicenseInfoFromJWT
2022/01/06 18:19:22 failed to verify license: exp not satisfied
=== RUN   TestGetLicenseInfoFromJWT/error_because_missing_license
=== RUN   TestGetLicenseInfoFromJWT/error_because_invalid_license
2022/01/06 18:19:22 Failed to parse public key: key must be a PEM encoded PKCS1 or PKCS8 key
=== RUN   TestGetLicenseInfoFromJWT/license_successfully_verified
2022/01/06 18:19:22 failed to verify license: exp not satisfied
    config_test.go:80: GetLicenseInfoFromJWT() error = invalid license key, wantErr false
--- FAIL: TestGetLicenseInfoFromJWT (0.09s)
    --- PASS: TestGetLicenseInfoFromJWT/error_because_missing_license (0.00s)
    --- PASS: TestGetLicenseInfoFromJWT/error_because_invalid_license (0.00s)
    --- FAIL: TestGetLicenseInfoFromJWT/license_successfully_verified (0.04s)

[dvaldivia]

@harshavardhana that test started failing today, also on other PRs that didn't had go changes

[jinapurapu]

Filenames with "?" are being modified on download

[harshavardhana]

TestGetLicenseInfoFromJWT

Well the stored license in the test has expired

{
  "alg": "ES384",
  "typ": "JWT"
}.{
  "sub": "[email protected]",
  "cap": 50,
  "org": "Gringotts Inc.",
  "exp": 1641446169.001199,
  "plan": "STANDARD",
  "iss": "[email protected]",
  "aid": 1,
  "iat": 1609910169.001199
}.[Signature]

Expired @dvaldivia

> Wed Jan 05 2022 21:16:09 GMT-0800 (Pacific Standard Time)

[harshavardhana]

NOTE we don't have JWT based license anymore and this test is meaningless..

[harshavardhana]

First step lets remove the test as it's not meaningful and then also remove the JWT parsing code - this is not valid anymore.

[prakashsvmx]

Filenames with "?" are being modified on download

@jinapurapu
This is a browser limitation/bug. it would replace < > * : and few more characters if we are downloading.

An Example:
Line 1: Original File name
Line 2 Downloaded file name

[harshavardhana]

Please rebase @adfost your PR.

[prakashsvmx]

👍

[Alevsk]

Suggested change

	let rspHeaderDecoded = decodeURIComponent(rspHeader);
	let rspHeaderDecoded = decodeFileName(rspHeader);

Please use the decodeFileName function located at portal-ui/src/common/utils.ts, that function will handle the error when a string cannot be decoded

[adfost]

Tried that that doesn't work

[bexsoft]

LGTM

PTAL @Alevsk