UI for Deleting PVC #1381
Merged
UI for Deleting PVC #1381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfost
requested review from
Alevsk,
bexsoft,
dvaldivia,
jinapurapu and
prakashsvmx
prakashsvmx
reviewed
Jan 12, 2022
portal-ui/src/screens/Console/Tenants/TenantDetails/DeletePVC.tsx
Outdated
Show resolved
Hide resolved
prakashsvmx
reviewed
Jan 12, 2022
portal-ui/src/screens/Console/Tenants/TenantDetails/DeletePVC.tsx
Outdated
Show resolved
Hide resolved
prakashsvmx
requested changes
Jan 12, 2022
Member
prakashsvmx
left a comment
prakashsvmx
left a comment
There was a problem hiding this comment.
Minor comments.
Otherwise changes look good to me.
portal-ui/src/screens/Console/Tenants/TenantDetails/VolumesSummary.tsx
Outdated
Show resolved
Hide resolved
portal-ui/src/screens/Console/Tenants/TenantDetails/VolumesSummary.tsx
Outdated
Show resolved
Hide resolved
dvaldivia
requested changes
Jan 12, 2022
Collaborator
dvaldivia
left a comment
dvaldivia
left a comment
There was a problem hiding this comment.
PR doesn't compile locally, imports are wrong.
Collaborator
|
After deleting a PVC, if I hit refresh the PVC's status field doesn't update accordingly to what kubernetes reports |
prakashsvmx
reviewed
Jan 13, 2022
portal-ui/src/screens/Console/Tenants/TenantDetails/VolumesSummary.tsx
Outdated
Show resolved
Hide resolved
Collaborator
|
I see the |
Collaborator
|
please rebase + squash |
dvaldivia
reviewed
Jan 19, 2022
adfost
force-pushed
the
delete_pvc2
branch
3 times, most recently
from
a4a29f5 to
c3a4e69
Compare
Collaborator
|
PTAL @prakashsvmx |
prakashsvmx
approved these changes
Jan 25, 2022
dvaldivia
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds UI for deleting PVCs.