Added Prometheus monitoring CPU and memory selector. #1387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinapurapu
requested review from
Alevsk,
adfost,
bexsoft,
dvaldivia and
prakashsvmx
dvaldivia
requested changes
Jan 13, 2022
Collaborator
dvaldivia
left a comment
dvaldivia
left a comment
There was a problem hiding this comment.
memory needs a unit, if we request 2 the value should be 2Gi in the CRD, also if the storage class is empty don't attach it
prometheus:
diskCapacityGB: 5
resources:
requests:
cpu: "2"
memory: "2"
storageClassName: ""
jinapurapu
force-pushed
the
monitoring-resource-selector
branch
from
5f26383 to
9a0b1e5
Compare
cniackz
reviewed
Jan 14, 2022
portal-ui/src/screens/Console/Tenants/TenantDetails/EditTenantMonitoringModal.tsx
Show resolved
Hide resolved
cniackz
approved these changes
Jan 14, 2022
Collaborator
cniackz
left a comment
cniackz
left a comment
There was a problem hiding this comment.
Looks good to me, just have a question, why the limit of requested CPUs is 10? Can it be 11?
Collaborator
|
@cniackz that is a nice catch, why are we limiting to upper 10 @jinapurapu ? it's not hat critical, but it's good to know |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added CPU and memory resource request fields for Prometheus monitoring