Added new features to bucket replication rules panel #1412
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bexsoft
requested review from
Alevsk,
adfost,
dvaldivia,
jinapurapu,
poornas and
prakashsvmx
bexsoft
force-pushed
the
edit-replication-rule
branch
2 times, most recently
from
a9edb1b to
66727bb
Compare
bexsoft
changed the title
bexsoft
force-pushed
the
edit-replication-rule
branch
from
66727bb to
fdb4151
Compare
bexsoft
force-pushed
the
edit-replication-rule
branch
from
fdb4151 to
f3ba046
Compare
bexsoft
force-pushed
the
edit-replication-rule
branch
from
f3ba046 to
dca7217
Compare
dvaldivia
previously approved these changes
Jan 19, 2022
poornas
requested changes
Jan 19, 2022
bexsoft
force-pushed
the
edit-replication-rule
branch
from
edb62f3 to
4e1e7ef
Compare
bexsoft
force-pushed
the
edit-replication-rule
branch
from
4e1e7ef to
41096d8
Compare
Collaborator
|
@poornas PTAL |
bexsoft
force-pushed
the
edit-replication-rule
branch
from
d096789 to
5fb2b7d
Compare
Collaborator
Author
|
Added selector for metadata replication. Regarding removing the validation for not deleting the last rule, minio-go sdk still contains this restriction. Will keep this behavior for now |
- Added Edit option for replication - Sorted by priority in replication list - Fixed an issue where storage class was not saved for replication rule - Added metadata replication selector to both add & edit windows Signed-off-by: Benjamin Perez <[email protected]>
bexsoft
force-pushed
the
edit-replication-rule
branch
from
af31e66 to
92a9075
Compare
poornas
approved these changes
Jan 20, 2022
dvaldivia
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
NOTE: Please test add & edit rules roughly as both modules were changed
How does it look?
Signed-off-by: Benjamin Perez [email protected]