Skip to content

Conversation

@cniackz
Copy link
Collaborator

@cniackz cniackz commented Jan 26, 2022

Fixes miniohq/engineering#453

To remove unused parameters from List Buckets end point at Console API

adfost
adfost previously approved these changes Jan 26, 2022
Copy link
Collaborator

@dvaldivia dvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check the swagger version, with v0.28.0 a lot of files get changed

➜ git status
On branch remove-limit
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   models/bucket_access.go
	modified:   models/bucket_encryption_type.go
	modified:   models/nofitication_service.go
	modified:   models/notification_event_type.go
	modified:   models/object_legal_hold_status.go
	modified:   models/object_retention_mode.go
	modified:   models/object_retention_unit.go
	modified:   models/policy_entity.go
	modified:   models/profiler_type.go

dvaldivia
dvaldivia previously approved these changes Jan 27, 2022
Copy link
Collaborator

@dvaldivia dvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will move to v0.29.0

jinapurapu
jinapurapu previously approved these changes Jan 27, 2022
@cniackz
Copy link
Collaborator Author

cniackz commented Jan 27, 2022

Daniel, I ran two commands inside this branch on this PR.

make swagger-gen
go mod tidy 

And there wasn't change in go.mod nor in go.sum like the other time I
modified these files in: #1393
I assume that dependencies are good to go. Nevertheless, I observe that we
don't have the latest of some of those dependencies, example:

github.com/go-openapi/errors v0.20.1 <----- this is an old version, should I up date it?

@cniackz cniackz dismissed stale reviews from jinapurapu, dvaldivia, and adfost via dded98a January 27, 2022 20:38
@cniackz
Copy link
Collaborator Author

cniackz commented Jan 27, 2022

Ok Daniel, I retrieved the latest versions from the repo's tags for go-openapi and swag and modified the go.mod and the go.sum accordingly.

@bexsoft bexsoft merged commit 4a1ccf1 into minio:master Jan 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants