Skip to content

Conversation

@bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Jan 26, 2022

What does this do?

Added redesign for buckets list menu actions & removes single action buttons from list

How does it look?

Screen Shot 2022-01-26 at 16 54 07

Screen Shot 2022-01-26 at 16 53 47

Screen Shot 2022-01-26 at 16 53 36

@bexsoft bexsoft changed the title [WIP] Bucket list actions menu Bucket list actions menu redesign Jan 26, 2022
@bexsoft bexsoft force-pushed the bucket-list-actions-menu branch from d478479 to 6deac92 Compare January 26, 2022 22:55
@bexsoft bexsoft self-assigned this Jan 26, 2022
Copy link
Collaborator

@dvaldivia dvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the dimensions and font size are a little off, but other than that it looks great, can we match the height 40 and fontSize: 14 and icon sizes ?
Screen Shot 2022-01-26 at 3 42 28 PM

@dvaldivia
Copy link
Collaborator

Screen Shot 2022-01-26 at 3 49 23 PM

I cannot create a new path (folder) on a prefix which I should.

Steps to repro:

1.- create bucket called mycache with a prefix mysoftware inside and place a file in mycache/mysoftware
2.- create a user with the following policy

{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Action": ["s3:ListBucket","s3:GetBucketLocation"],
      "Effect": "Allow",
      "Resource": ["arn:aws:s3:::mycache"]
    },
    {
      "Action": ["s3:ListBucket","s3:GetObject"],
      "Effect": "Allow",
      "Resource": ["arn:aws:s3:::mycache/*"]
    },
    {
      "Action": [
        "s3:ListBucket",
        "s3:GetObject",
        "s3:PutObject",
        "s3:DeleteObject"
      ],
      "Effect": "Allow",
      "Resource": ["arn:aws:s3:::mycache/mysoftware/*"]
    }
  ]
}

3.- go to mycache > Browse > mysoftware
4.- I should be allowed to create a subfolder

@bexsoft bexsoft force-pushed the bucket-list-actions-menu branch from 0a01e0d to 7dd7f14 Compare January 27, 2022 03:25
@bexsoft bexsoft force-pushed the bucket-list-actions-menu branch from ad40e3a to 4fe1ca7 Compare January 27, 2022 04:14
@bexsoft
Copy link
Collaborator Author

bexsoft commented Jan 27, 2022

the dimensions and font size are a little off, but other than that it looks great, can we match the height 40 and fontSize: 14 and icon sizes ? Screen Shot 2022-01-26 at 3 42 28 PM

Solved:
Screen Shot 2022-01-26 at 22 15 14

@bexsoft
Copy link
Collaborator Author

bexsoft commented Jan 27, 2022

Screen Shot 2022-01-26 at 3 49 23 PM

I cannot create a new path (folder) on a prefix which I should.
Steps to repro:

1.- create bucket called mycache with a prefix mysoftware inside and place a file in mycache/mysoftware 2.- create a user with the following policy

{
  "Version": "2012-10-17",
  "Statement": [
    {
      "Action": ["s3:ListBucket","s3:GetBucketLocation"],
      "Effect": "Allow",
      "Resource": ["arn:aws:s3:::mycache"]
    },
    {
      "Action": ["s3:ListBucket","s3:GetObject"],
      "Effect": "Allow",
      "Resource": ["arn:aws:s3:::mycache/*"]
    },
    {
      "Action": [
        "s3:ListBucket",
        "s3:GetObject",
        "s3:PutObject",
        "s3:DeleteObject"
      ],
      "Effect": "Allow",
      "Resource": ["arn:aws:s3:::mycache/mysoftware/*"]
    }
  ]
}

3.- go to mycache > Browse > mysoftware 4.- I should be allowed to create a subfolder

This issue seems to be already present as hasPermissions function is returning me false in master too. This is not related to this PR, and will be fixed in another one

@bexsoft bexsoft requested a review from dvaldivia January 27, 2022 04:16
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested.

  • Un Versioned Bucket/Objects
  • Versioned Bucket/Objects

Changes look good to me.

@dvaldivia dvaldivia merged commit c129eae into minio:master Jan 27, 2022
@bexsoft bexsoft deleted the bucket-list-actions-menu branch January 27, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants