Skip to content

Customized calendar & time pickers for DateTimePicker component #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 3, 2022
Merged

Customized calendar & time pickers for DateTimePicker component #1508

merged 3 commits into from
Feb 3, 2022

Conversation

@bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Feb 3, 2022

What does this do?

Customized the modificable styles for calendar & time picker for DateTimePicker component

Notes

  • Component to display full date & time inside calendar dropdown is not customizable, so that change was not applied
  • Spacing at the bottom of the calendar is necessary for months with 6 weeks (Eg. Jan & July 2022), No configuration available to avoid this.
  • There is an issue reported in safari with this component where some outlines are present during component first render:

Screen Shot 2022-02-02 at 17 45 34

How does it look?

Screen Shot 2022-02-02 at 18 11 03

Screen Shot 2022-02-02 at 18 10 59

Screen Shot 2022-02-02 at 18 10 49

Screen Shot 2022-02-02 at 18 10 43

Screen Shot 2022-02-02 at 18 19 57

Signed-off-by: Benjamin Perez [email protected]

@bexsoft bexsoft self-assigned this Feb 3, 2022
prakashsvmx
prakashsvmx approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bexsoft bexsoft merged commit 52ea198 into minio:master Feb 3, 2022
@bexsoft bexsoft deleted the date-redesign branch February 3, 2022 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dvaldivia dvaldivia dvaldivia approved these changes

@prakashsvmx prakashsvmx prakashsvmx approved these changes

@Alevsk Alevsk Awaiting requested review from Alevsk

@cniackz cniackz Awaiting requested review from cniackz

@adfost adfost Awaiting requested review from adfost

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

Assignees

@bexsoft bexsoft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bexsoft @dvaldivia @prakashsvmx