Skip to content

Service account policy UI #1519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 9, 2022
Merged

Service account policy UI #1519

merged 8 commits into from
Feb 9, 2022

Conversation

@adfost
Copy link
Contributor

@adfost adfost commented Feb 4, 2022

UI for getting service account policies
Screen Shot 2022-02-04 at 11 04 33 AM
.

@adfost adfost changed the title Service account policy UI 2 Service account policy UI Feb 4, 2022
dvaldivia
dvaldivia requested changes Feb 4, 2022
View reviewed changes
@adfost adfost requested a review from dvaldivia February 5, 2022 00:24
@harshavardhana
Copy link
Member

harshavardhana commented Feb 5, 2022

Do we validate if its an invalid JSON in the UI?

@harshavardhana
Copy link
Member

harshavardhana commented Feb 5, 2022

Like do we react to what they pasted? - the way we are highlighting it has JSON, are we able to validate/parse it as well?

@prakashsvmx
Copy link
Member

prakashsvmx commented Feb 8, 2022

@adfost Please resolve the conflicts.

prakashsvmx
prakashsvmx previously approved these changes Feb 8, 2022
View reviewed changes
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. 👍

Few minor changes can be part of #1525

@Alevsk
Copy link
Contributor

Alevsk commented Feb 8, 2022

Like do we react to what they pasted? - the way we are highlighting it has JSON, are we able to validate/parse it as well?

I think that highlight happens automatically by the CodeMirror library, currently theres no validation in place to check if whatever the user input its a valid json, however if the json is wrong minio will return an error and we will display that on the UI

Alevsk
Alevsk previously approved these changes Feb 8, 2022
View reviewed changes
dvaldivia
dvaldivia requested changes Feb 8, 2022
View reviewed changes
Copy link
Collaborator

@dvaldivia dvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I create a SA without policy, it shows me a weird policy, if the SA has no policy, we should show empty
Screen Shot 2022-02-08 at 10 37 18 AM

@adfost adfost dismissed stale reviews from Alevsk and prakashsvmx via 6d43dd9 February 8, 2022 23:16
dvaldivia
dvaldivia approved these changes Feb 9, 2022
View reviewed changes
Copy link
Collaborator

@dvaldivia dvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM

prakashsvmx
prakashsvmx approved these changes Feb 9, 2022
View reviewed changes
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dvaldivia dvaldivia merged commit 75b3082 into minio:master Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dvaldivia dvaldivia dvaldivia approved these changes

@prakashsvmx prakashsvmx prakashsvmx approved these changes

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

@bexsoft bexsoft Awaiting requested review from bexsoft

@cniackz cniackz Awaiting requested review from cniackz

@Alevsk Alevsk Awaiting requested review from Alevsk

Assignees

@adfost adfost

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@adfost @harshavardhana @prakashsvmx @Alevsk @dvaldivia