-
Notifications
You must be signed in to change notification settings - Fork 514
Inspect API #1540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inspect API #1540
Conversation
|
When I reach an invalid path (invalid bucket or objects) , I get status response |
The API is not designed to get 404 it's expected to see failures since it's a "debugging" API - Do not think of it like S3 API as it is allowed to download any path any file in its RAW form. Like you can download
The response is a Zip stream, so failures are allowed and normal. |
|
The UI should be designed to support these requirements |
905bd62 to
b600c41
Compare
bexsoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Inspect API (
mc admin inspect [--encrypt] <alias> <path>)Steps to Test:
.encfile will be generated along with a decryption keyinspecttool and enter the decryption key to get the.zipfilexl-metatool to verify the contents of.zipfilexl-metatool to verify the contents of.zipfile.API URL :
/api/v1/admin/inspect?file=test.txt%2Fxl.meta&volume=test-bucket&encrypt=trueFixes https://github.com/miniohq/engineering/issues/479