Skip to content

UI for Inspect #1583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 22, 2022
Merged

UI for Inspect #1583

merged 7 commits into from
Feb 22, 2022

Conversation

@prakashsvmx
Copy link
Member

@prakashsvmx prakashsvmx commented Feb 16, 2022 •
edited
Loading

@prakashsvmx prakashsvmx self-assigned this Feb 16, 2022
dvaldivia
dvaldivia requested changes Feb 16, 2022
View reviewed changes
Copy link
Collaborator

@dvaldivia dvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need js-cookie and file-saver ?

dvaldivia
dvaldivia previously approved these changes Feb 16, 2022
View reviewed changes
@cniackz cniackz self-requested a review February 16, 2022 18:11
cniackz
cniackz reviewed Feb 16, 2022
View reviewed changes
Copy link
Collaborator

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a testcafe test for this added UI?

@dvaldivia
Copy link
Collaborator

dvaldivia commented Feb 16, 2022

that's a great idea @cniackz

jinapurapu
jinapurapu reviewed Feb 17, 2022
View reviewed changes
bexsoft
bexsoft reviewed Feb 17, 2022
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Please handle @jinapurapu comments, Thank you!

@cniackz
Copy link
Collaborator

cniackz commented Feb 18, 2022 •
edited
Loading

Tested, it works:
Screen Shot 2022-02-18 at 12 55 06 PM

Just a note of caution, don't run this over minio not distributed, will fail
Run instead over a distributed minio, I am currently using my USB Stick for this testing:
minio server /Volumes/data{1...4}

Also, tested directly with mc command to learn:

cniackz:/Users/cniackz/test-bucket # mc admin inspect myminio/test-bucket/file.txt/xl.meta              
mc: File data successfully downloaded as inspect.79bbbccc.zip

@cniackz cniackz self-requested a review February 18, 2022 17:57
cniackz
cniackz previously approved these changes Feb 18, 2022
View reviewed changes
Copy link
Collaborator

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good to me. Later on we can add the test if is not added here!...

@prakashsvmx
Copy link
Member Author

prakashsvmx commented Feb 19, 2022

Marking this as WIP as I will remove the packages and add some test in this PR itself.

@prakashsvmx prakashsvmx changed the title UI for Inspect [WIP] UI for Inspect Feb 19, 2022
@prakashsvmx prakashsvmx dismissed stale reviews from cniackz and dvaldivia via a0d1545 February 19, 2022 12:55
@prakashsvmx prakashsvmx changed the title [WIP] UI for Inspect UI for Inspect Feb 19, 2022
@prakashsvmx
Copy link
Member Author

prakashsvmx commented Feb 19, 2022

@dvaldivia @bexsoft @cniackz @jinapurapu Thank you for the review and feedback. I have updated accordingly. PTAL

dvaldivia
dvaldivia approved these changes Feb 22, 2022
View reviewed changes
Copy link
Collaborator

@dvaldivia dvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. LGTM.

bexsoft
bexsoft approved these changes Feb 22, 2022
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bexsoft bexsoft merged commit 006b3c7 into minio:master Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jinapurapu jinapurapu jinapurapu left review comments

@dvaldivia dvaldivia dvaldivia approved these changes

@bexsoft bexsoft bexsoft approved these changes

@cniackz cniackz cniackz left review comments

@Alevsk Alevsk Awaiting requested review from Alevsk

@adfost adfost Awaiting requested review from adfost

Assignees

@prakashsvmx prakashsvmx

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@prakashsvmx @dvaldivia @cniackz @bexsoft @jinapurapu