Skip to content

Conversation

@adfost
Copy link
Contributor

@adfost adfost commented Apr 7, 2022

Fixes https://github.com/miniohq/engineering/issues/688.

How to reproduce this issue for testing

  1. Export these variables below
export CONSOLE_ACCESS_KEY=x
export CONSOLE_SECRET_KEY=x
export CONSOLE_HMAC_JWT_SECRET=x
export CONSOLE_PBKDF_PASSPHRASE=x
export CONSOLE_PBKDF_SALT=x
export CONSOLE_M3_HOSTNAME=http://localhost:8787
export CONSOLE_HOSTNAME=0.0.0.0
export CONSOLE_IDP_URL=https://x/.well-known/openid-configuration
export CONSOLE_IDP_CLIENT_ID=x
export CONSOLE_IDP_SECRET=x
export CONSOLE_IDP_CALLBACK=http://localhost:5005/oauth_callback
export CONSOLE_OPERATOR_SA_TOKEN=x-x-x-x--x-x;
export CGO_ENABLED=0x```
2. Compile console server and run it on operator mode:

```sh
cd ~/console                          
make install
~/go/bin/console operator
  1. Open the UI to login

Screen Shot 2022-04-08 at 1 26 01 PM

This is wrong, exepcted is Operator Login Text

  1. Test on port 5005:
cd ~/console/portal-ui
yarn install
yarn build
yarn run start
  1. Open login page in 5005 port

Screen Shot 2022-04-08 at 1 32 14 PM

If you see Operator message then issue got fixed.

Additional information:

https://github.com/minio/operator/wiki/How-to-test-Operator-Login

@adfost adfost force-pushed the operator_mode_sso_bug branch from 5dd5a44 to c2297b8 Compare April 7, 2022 18:17
Copy link
Collaborator

@dvaldivia dvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screen Shot 2022-04-07 at 10 35 13 AM

please make sure to be using the right prettier version, seems like some of these changes are not needed

@adfost adfost requested a review from dvaldivia April 7, 2022 22:54
@cniackz
Copy link
Collaborator

cniackz commented Apr 8, 2022

Ok, documented and tested this code: https://github.com/minio/operator/wiki/How-to-test-Operator-Login

cniackz
cniackz previously approved these changes Apr 8, 2022
Copy link
Collaborator

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me, just address the changes from Daniel if not already you did

Copy link
Collaborator

@dvaldivia dvaldivia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adfost adfost requested a review from Alevsk April 18, 2022 17:00
@adfost adfost requested a review from cniackz April 18, 2022 17:00
Copy link
Contributor

@Alevsk Alevsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works fine, approved 👍

@dvaldivia dvaldivia merged commit f36c07a into minio:master Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants