-
Notifications
You must be signed in to change notification settings - Fork 514
Fixing SSO Operator mode showing CONSOLE #1808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5dd5a44 to
c2297b8
Compare
dvaldivia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
Ok, documented and tested this code: https://github.com/minio/operator/wiki/How-to-test-Operator-Login |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good to me, just address the changes from Daniel if not already you did
dvaldivia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Alevsk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works fine, approved 👍

Fixes https://github.com/miniohq/engineering/issues/688.
How to reproduce this issue for testing
Additional information:
https://github.com/minio/operator/wiki/How-to-test-Operator-Login