Skip to content

Correcting error message to be same as our code #1851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2022
Merged

Correcting error message to be same as our code #1851

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions restapi/user_watch_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,27 +167,27 @@ func TestWatch(t *testing.T) {
}
wo.Events() <- info
}
wo.Errors() <- &probe.Error{Cause: fmt.Errorf("error on Watch")}
wo.Errors() <- &probe.Error{Cause: fmt.Errorf("error on watch")}
}(wo)
return wo, nil
}
connWriteMessageMock = func(messageType int, data []byte) error {
return nil
}
if err := startWatch(ctx, mockWSConn, client, testOptions); assert.Error(err) {
assert.Equal("error on Watch", err.Error())
assert.Equal("error on watch", err.Error())
}

// Test-4: error happens on Watch, watch should stop
// and error shall be returned.
mcWatchMock = func(ctx context.Context, params mc.WatchOptions) (*mc.WatchObject, *probe.Error) {
return nil, &probe.Error{Cause: fmt.Errorf("error on Watch")}
return nil, &probe.Error{Cause: fmt.Errorf("error on watch")}
}
if err := startWatch(ctx, mockWSConn, client, testOptions); assert.Error(err) {
assert.Equal("error on Watch", err.Error())
assert.Equal("error on watch", err.Error())
}

// Test-5: return nil on error on Watch
// Test-5: return nil on error on watch
mcWatchMock = func(ctx context.Context, params mc.WatchOptions) (*mc.WatchObject, *probe.Error) {
wo := &mc.WatchObject{
EventInfoChan: make(chan []mc.EventInfo),
Expand Down