Moved AddUser from modal to screen #1869
Conversation
jinapurapu
requested review from
Alevsk,
adfost,
bexsoft,
cniackz,
dvaldivia,
kaankabalak,
oscarocastellanos and
prakashsvmx
oscarocastellanos
left a comment
oscarocastellanos
left a comment
There was a problem hiding this comment.
The assign groups search box should have more space on top so it doesn't clash with the previous box.
Icons in the help bar should be smaller and just one color. Please let me know if you need me to adjust the icons.
Is it possible to use the side by side help box format as @prakashsvmx has been doing in other recent screens?
|
I think it's just some extra alignment
|
dvaldivia
left a comment
dvaldivia
left a comment
There was a problem hiding this comment.
There's a couple of issues, on error we are still redirecting, so avoid redirecting on error, also when we successfully ad we don't refresh the list of users, that might be a bug on user list screen
|
Can you align like this @jinapurapu ? |
jinapurapu
force-pushed
the
add_user_screen
branch
from
5153cc0 to
125ba09
Compare
jinapurapu
force-pushed
the
add_user_screen
branch
from
125ba09 to
63c76e5
Compare
oscarocastellanos
left a comment
oscarocastellanos
left a comment
There was a problem hiding this comment.
Icon should be correctly aligned and also the upper most field to the help box
6 participants
How it looks:
Closes https://github.com/miniohq/engineering/issues/726