Fixing Permissions Tests Part 2 #1884
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cniackz
changed the title
cniackz
changed the title
cniackz
requested review from
Alevsk,
adfost,
bexsoft,
dvaldivia,
harshavardhana,
jinapurapu,
kaankabalak and
prakashsvmx
cniackz
added
enhancement
jinapurapu
approved these changes
Apr 21, 2022
bexsoft
approved these changes
Apr 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix the problem that we are facing with
Permissions Tests Part 2, I decided to split the tests in more folders and that is fixing current issue.My best guess, since I couldn't reproduce this locally, it is that there is a racing condition between these tests that are always affecting one of these 3 below:
This change is not affecting execution time, since they run in parallel as we may know by looking at the diagram: