Skip to content

config set should always use on/off not true/false #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022
Merged

config set should always use on/off not true/false #1899

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions portal-ui/src/screens/Console/NotificationEndpoints/ConfTargetGeneric.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ export const valueDef = (
type: string,
defaults: IElementValue[]
) => {
let defValue = type === "on|off" ? "false" : "";
let defValue = type === "on|off" ? "off" : "";

if (defaults.length > 0) {
const storedConfig = defaults.find((element) => element.key === key);
Expand Down Expand Up @@ -105,20 +105,20 @@ const ConfTargetGeneric = ({
const fieldDefinition = (field: KVField, item: number) => {
switch (field.type) {
case "on|off":
const value = valueHolder[item] ? valueHolder[item].value : "false";
const value = valueHolder[item] ? valueHolder[item].value : "off";

return (
<FormSwitchWrapper
onChange={(e: React.ChangeEvent<HTMLInputElement>) => {
const value = e.target.checked ? "true" : "false";
const value = e.target.checked ? "on" : "off";
setValueElement(field.name, value, item);
}}
id={field.name}
name={field.name}
label={field.label}
value={"switch_on"}
tooltip={field.tooltip}
checked={value === "true"}
checked={value === "on"}
/>
);
case "csv":
Expand Down