Permissions Tests Part 5 (1.17.x, ubuntu-latest) #1958
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cniackz
changed the title
cniackz
force-pushed
the
fix-permissions-tests-part-5
branch
from
1d16dfb to
6e9bb76
Compare
cniackz
requested review from
Alevsk,
adfost,
bexsoft,
harshavardhana,
jinapurapu and
prakashsvmx
dvaldivia
approved these changes
May 6, 2022
kaankabalak
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: https://github.com/miniohq/engineering/issues/822
Root cause: This is a MinIO Issue on Diagnostic Tool, where sometimes when we click on start new diag it just fail:
//div[text()='An error occurred while getting Diagnostic file.']<--- The selector.We are testing the UI, not backend MinIO Diag tool.
So let's just wait or click for the buttons when diag actually works.