Skip to content

Disabled support tools if cluster is not registered. #2168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 28, 2022
Merged

Disabled support tools if cluster is not registered. #2168

merged 15 commits into from
Oct 28, 2022

Conversation

@bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Jul 12, 2022

What does this do?

  • Redirect to register page when not register vars are set
  • Added double column for register page

How does it look?

Screen Shot 2022-07-12 at 14 41 53

Screen Shot 2022-07-12 at 14 41 46

Screen Shot 2022-07-12 at 14 41 38

Screen Shot 2022-07-12 at 14 36 50

Screen Shot 2022-07-12 at 14 36 43

Screen Shot 2022-07-12 at 14 36 35

Screen Shot 2022-07-12 at 14 36 28

Signed-off-by: Benjamin Perez [email protected]

@bexsoft bexsoft added the WIP This PR is WIP and cannot be merged yet label Jul 12, 2022
@bexsoft bexsoft self-assigned this Jul 12, 2022
@bexsoft bexsoft force-pushed the disable-support-non-activated branch 2 times, most recently from e683e35 to f4d9952 Compare July 13, 2022 22:42
@bexsoft
Copy link
Collaborator Author

bexsoft commented Jul 13, 2022

Updated screens:
Screen Shot 2022-07-13 at 17 42 44
Screen Shot 2022-07-13 at 17 42 27

reivaj05
reivaj05 reviewed Jul 13, 2022
View reviewed changes
@bexsoft bexsoft changed the title [WIP] Disabled support tools if cluster is not registered. Disabled support tools if cluster is not registered. Jul 14, 2022
@bexsoft bexsoft removed the WIP This PR is WIP and cannot be merged yet label Jul 14, 2022
@bexsoft bexsoft force-pushed the disable-support-non-activated branch from f4d9952 to 6665306 Compare July 14, 2022 19:31
reivaj05
reivaj05 previously approved these changes Jul 15, 2022
View reviewed changes
@harshavardhana
Copy link
Member

harshavardhana commented Jul 15, 2022

Does this mean that an unregistered cluster can't run speedtest?

@harshavardhana
Copy link
Member

harshavardhana commented Jul 16, 2022

Does this mean that an unregistered cluster can't run speedtest?

any answer to my question?

@bexsoft
Copy link
Collaborator Author

bexsoft commented Jul 16, 2022

Does this mean that an unregistered cluster can't run speedtest?

Yes, that's correct

@harshavardhana
Copy link
Member

harshavardhana commented Jul 16, 2022

Yes, that's correct

Isn't this going to be a breaking change and perhaps a large change for even POC customers? - are we saying that even POCs will have to be registered?

@bexsoft
Copy link
Collaborator Author

bexsoft commented Jul 16, 2022

Yes, that's correct

Isn't this going to be a breaking change and perhaps a large change for even POC customers? - are we saying that even POCs will have to be registered?

I see, yeah the requirement was to request for register the cluster to enable the tools actions. I think we might need to review this further.

@reivaj05
Copy link
Contributor

reivaj05 commented Jul 18, 2022

If possible can we commit the changes to Register.tsx file in a different PR? I believe those changes can go without any problem but not 100% sure

@reivaj05 reivaj05 mentioned this pull request Jul 18, 2022
Merged
@bexsoft bexsoft force-pushed the disable-support-non-activated branch 2 times, most recently from 4e3eca3 to d544559 Compare July 29, 2022 20:36
@reivaj05 reivaj05 mentioned this pull request Aug 2, 2022
Merged
@bexsoft bexsoft force-pushed the disable-support-non-activated branch from d544559 to e54ecd9 Compare August 3, 2022 00:01
cniackz
cniackz reviewed Aug 9, 2022
View reviewed changes
Copy link
Collaborator

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked, no need for a review right now.

@bexsoft bexsoft changed the title [Blocked] - Disabled support tools if cluster is not registered. Disabled support tools if cluster is not registered. Oct 7, 2022
@bexsoft bexsoft added WIP This PR is WIP and cannot be merged yet and removed blocked labels Oct 7, 2022
@bexsoft bexsoft force-pushed the disable-support-non-activated branch from 8b39ad9 to 2f82e26 Compare October 10, 2022 03:56
Disabled support tools if cluster is not registered.
45ba17c 
- Redirect to register page when not register vars are set
- Added double column for register page

Signed-off-by: Benjamin Perez <[email protected]>
@bexsoft bexsoft force-pushed the disable-support-non-activated branch from 2f82e26 to 45ba17c Compare October 10, 2022 04:03
@bexsoft bexsoft requested review from cniackz and reivaj05 October 10, 2022 04:03
@bexsoft bexsoft removed the WIP This PR is WIP and cannot be merged yet label Oct 10, 2022
@bexsoft
Copy link
Collaborator Author

bexsoft commented Oct 25, 2022

This PR is blocked, no need for a review right now.

PR Ready for review

@dvaldivia dvaldivia merged commit a2745c6 into minio:master Oct 28, 2022
@dvaldivia dvaldivia deleted the disable-support-non-activated branch October 28, 2022 20:04
adfost pushed a commit to adfost/console that referenced this pull request Nov 18, 2022
@bexsoft @adfost
Disabled support tools if cluster is not registered. (minio#2168)
a6e2387 
- Redirect to register page when not register vars are set
- Added double column for register page

Signed-off-by: Benjamin Perez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@reivaj05 reivaj05 reivaj05 approved these changes

@adfost adfost Awaiting requested review from adfost

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

@prakashsvmx prakashsvmx Awaiting requested review from prakashsvmx

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

@cniackz cniackz Awaiting requested review from cniackz

+1 more reviewer

@Alevsk Alevsk Alevsk approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@bexsoft bexsoft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@bexsoft @harshavardhana @reivaj05 @Alevsk @cniackz @dvaldivia