Skip to content

Conversation

@bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Aug 9, 2022

What does this do?

Removed permanent scrollbar in embedded object browser

How does it look?

Screen Shot 2022-08-08 at 19 43 01

Screen Shot 2022-08-08 at 19 42 40

Screen Shot 2022-08-08 at 19 42 32

Signed-off-by: Benjamin Perez [email protected]

Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified. Changes look good to me 👍
The Desktop view has only one scrollbar.

Note: Tablet/Mobile view has 2 scrollbars. ( it can be fixed in a different PR if it is not a priority).

image

Mobile view

image

@cniackz
Copy link
Collaborator

cniackz commented Aug 9, 2022

Approved, but why is that we are failing on Operator UI Tests:

For user with default permissions
 ✓ Create Tenant and List Tenants
 ✓ Create Tenant Without Audit Log
 ✓ Test describe section for PODs in new tenant
 ✓ Test describe section for PVCs in new tenant
 ✓ Test Prometheus monitoring can be disabled and enabled
 ✖ Test Prometheus config fields can be edited and submitted

   1) The specified selector does not match any element in the DOM tree.

       > | Selector('#prometheus_image')

      Browser: Chrome 103.0.5060.134 / Linux 0.0

         1[31](https://github.com/minio/console/runs/7737343270?check_suite_focus=true#step:12:32) |    .ok();
         1[32](https://github.com/minio/console/runs/7737343270?check_suite_focus=true#step:12:33) |};
         1[33](https://github.com/minio/console/runs/7737343270?check_suite_focus=true#step:12:34) |export const checkMonitoringFieldsAcceptValues = async (tenantName: string) => {
         1[34](https://github.com/minio/console/runs/7737343270?check_suite_focus=true#step:12:35) |  await goToMonitoringSection(tenantName);
         1[35](https://github.com/minio/console/runs/7737343270?check_suite_focus=true#step:12:36) |  await t
       > 1[36](https://github.com/minio/console/runs/7737343270?check_suite_focus=true#step:12:37) |    .typeText("#prometheus_image", "quay.io/prometheus/prometheus:latest", {
         1[37](https://github.com/minio/console/runs/7737343270?check_suite_focus=true#step:12:38) |      replace: true,
         1[38](https://github.com/minio/console/runs/7737343270?check_suite_focus=true#step:12:39) |    })
         1[39](https://github.com/minio/console/runs/7737343270?check_suite_focus=true#step:12:40) |    .typeText("#sidecarImage", "library/alpine:latest", { replace: true })
         1[40](https://github.com/minio/console/runs/7737343270?check_suite_focus=true#step:12:41) |    .typeText("#initImage", "library/busybox:1.33.1", { replace: true })
         1[41](https://github.com/minio/console/runs/7737343270?check_suite_focus=true#step:12:42) |    .typeText("#diskCapacityGB", "1", { replace: true })

         at <anonymous> (/home/runner/work/console/console/portal-ui/tests/operator/tenants.ts:136:6)
         at fulfilled (/home/runner/work/console/console/portal-ui/tests/operator/tenants.ts:20:58)


 ✓ Test Audit Logging can be disabled and enabled
 ✓ Test Audit Log config fields can be edited and submitted

Will re run this test.

Copy link
Collaborator

@cniackz cniackz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I want to see if Operator UI Tests is not broken by this change.

@bexsoft bexsoft merged commit 4aa3f40 into minio:master Aug 9, 2022
@bexsoft bexsoft deleted the embed-fixes branch August 9, 2022 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants