Skip to content

Improved policy create policy screen #2268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2022
Merged

Improved policy create policy screen #2268

merged 1 commit into from
Aug 26, 2022

Conversation

@bexsoft
Copy link
Collaborator

@bexsoft bexsoft commented Aug 25, 2022

fixes https://github.com/minio/console/issues/2257

What does this do?

Adds a border & min-height to CodeEditor plugin.

Don't allow to create an empty policy

How does it look?

Screen Shot 2022-08-24 at 19 13 03

Screen Shot 2022-08-24 at 19 12 45

Signed-off-by: Benjamin Perez [email protected]

@bexsoft bexsoft self-assigned this Aug 25, 2022
@bexsoft bexsoft force-pushed the policy-field-issue branch from b359b86 to 82987d7 Compare August 25, 2022 00:17
@dvaldivia
Copy link
Collaborator

dvaldivia commented Aug 25, 2022

Can you also add a bootstrap policy with empty statements array?

@bexsoft bexsoft force-pushed the policy-field-issue branch from ce55a13 to 0bdc93c Compare August 25, 2022 03:06
@bexsoft
Copy link
Collaborator Author

bexsoft commented Aug 25, 2022

Can you also add a bootstrap policy with empty statements array?

Done
Screen Shot 2022-08-24 at 22 07 25

@udf2457
Copy link

udf2457 commented Aug 25, 2022

@bexsoft FYI don't forget buckets also have a policy edit option (Manage bucket -> Access policy -> custom)

@dvaldivia
Copy link
Collaborator

dvaldivia commented Aug 25, 2022

test Created Policy can be viewed and deleted on Tests 1 is failing

@bexsoft
Copy link
Collaborator Author

bexsoft commented Aug 25, 2022

@bexsoft FYI don't forget buckets also have a policy edit option (Manage bucket -> Access policy -> custom)

Yes, Style change affects this globally. Will add an empty policy here too. Thank you for the suggestion :)

Screen Shot 2022-08-25 at 10 33 09

@bexsoft bexsoft force-pushed the policy-field-issue branch from b00b7db to d0ea82c Compare August 25, 2022 18:11
@bexsoft
Copy link
Collaborator Author

bexsoft commented Aug 25, 2022

test Created Policy can be viewed and deleted on Tests 1 is failing

Fixed.

prakashsvmx
prakashsvmx approved these changes Aug 26, 2022
View reviewed changes
Copy link
Member

@prakashsvmx prakashsvmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. Changes look good to me. 👍

A cosmetic Observation:
in the raw policy view, there are 2 border lines around the policy editor
image

@bexsoft bexsoft merged commit f11b9bf into minio:master Aug 26, 2022
@bexsoft bexsoft deleted the policy-field-issue branch August 30, 2022 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@prakashsvmx prakashsvmx prakashsvmx approved these changes

@jinapurapu jinapurapu jinapurapu approved these changes

@pjuarezd pjuarezd Awaiting requested review from pjuarezd

@Alevsk Alevsk Awaiting requested review from Alevsk

@cniackz cniackz Awaiting requested review from cniackz

@reivaj05 reivaj05 Awaiting requested review from reivaj05

@adfost adfost Awaiting requested review from adfost

@dvaldivia dvaldivia Awaiting requested review from dvaldivia

Assignees

@bexsoft bexsoft

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

EOF on creating new policy in GUI

5 participants

@bexsoft @dvaldivia @udf2457 @prakashsvmx @jinapurapu