Display configured logger_webhook endpoints #2279
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinapurapu
requested review from
Alevsk,
bexsoft,
cniackz,
dvaldivia,
kaankabalak,
prakashsvmx and
reivaj05
Collaborator
|
Tested locally, I can see and create the endpoints:
|
jinapurapu
force-pushed
the
logger_webhook_ui_fix
branch
from
dfc5f43 to
14f9f5f
Compare
Collaborator
|
Please review lint in go files & squash commits into a single one |
Rendered configured endpoints and names on webhook config screens
jinapurapu
force-pushed
the
logger_webhook_ui_fix
branch
from
14f9f5f to
4485437
Compare
added 2 commits
August 30, 2022 15:53
reivaj05
approved these changes
Aug 31, 2022
kaankabalak
approved these changes
Sep 1, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes https://github.com/miniohq/engineering/issues/964