-
Notifications
You must be signed in to change notification settings - Fork 512
Support for providing Tenant client certificates #2294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
oscarocastellanos
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d79def0 to
3bfc7a1
Compare
7783862 to
b0127c1
Compare
- Support for upload client certificates during tenant creation - Support for adding client certificates for existing tenants - Don't restart all pods at the same time when updating security configuration, instead do rollout restart - Adding `parseTenantCertificates` function tests Signed-off-by: Lenin Alevski <[email protected]>
b0127c1 to
2541e3c
Compare
bexsoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
I see console errors, but some are related to other PR, like: #2139 I will fix some of these console errors in a separate PR. |
cniackz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM



configuration, instead do rollout restart
Signed-off-by: Lenin Alevski [email protected]