-
Notifications
You must be signed in to change notification settings - Fork 512
Toggle Bucket Naming Rules display by clicking text #2311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toggle Bucket Naming Rules display by clicking text #2311
Conversation
portal-ui/src/screens/Console/Buckets/ListBuckets/AddBucket/BucketNamingRules.tsx
Outdated
Show resolved
Hide resolved
portal-ui/src/screens/Console/Buckets/ListBuckets/AddBucket/BucketNamingRules.tsx
Outdated
Show resolved
Hide resolved
portal-ui/src/screens/Console/Buckets/ListBuckets/AddBucket/BucketNamingRules.tsx
Outdated
Show resolved
Hide resolved
portal-ui/src/screens/Console/Buckets/ListBuckets/AddBucket/BucketNamingRules.tsx
Outdated
Show resolved
Hide resolved
|
@jinapurapu, as we already have the same toggle function associated with both diff --git a/portal-ui/src/screens/Console/Buckets/ListBuckets/AddBucket/BucketNamingRules.tsx b/portal-ui/src/screens/Console/Buckets/ListBuckets/AddBucket/BucketNamingRules.tsx
index 651877c3..afcf5ff3 100644
--- a/portal-ui/src/screens/Console/Buckets/ListBuckets/AddBucket/BucketNamingRules.tsx
+++ b/portal-ui/src/screens/Console/Buckets/ListBuckets/AddBucket/BucketNamingRules.tsx
@@ -63,26 +63,15 @@ const BucketNamingRules = ({ errorList }: { errorList: boolean[] }) => {
return (
<Fragment>
<Grid item xs={12}>
- {showNamingRules ? (
- <span
- onClick={() => {
- toggleNamingRules();
- }}
- style={{ color: "#0288D1", textDecoration: "underline" }}
- >
- {" "}
- Hide Bucket Naming Rules{" "}
- </span>
- ) : (
- <span
- onClick={() => {
- toggleNamingRules();
- }}
- style={{ color: "#0288D1", textDecoration: "underline" }}
- >
- View Bucket Naming Rules
- </span>
- )}
+ <span
+ onClick={() => {
+ toggleNamingRules();
+ }}
+ style={{ color: "#0288D1", textDecoration: "underline", cursor: "pointer", fontSize: "14px" }}
+ >
+ {showNamingRules ? "Hide" : "View"}
+ {" Bucket Naming Rules"}
+ </span>
<Button
variant="text"
size="small"
|
3a25139 to
e256f65
Compare
portal-ui/src/screens/Console/Buckets/ListBuckets/AddBucket/BucketNamingRules.tsx
Show resolved
Hide resolved
bexsoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5b6cf74 to
58b9f2e
Compare
bexsoft
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds show/hide rules toggle to text adjacent to button.

