Return 401 for Login Errors #2312
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvaldivia
requested review from
Alevsk,
bexsoft,
cniackz,
jinapurapu,
kaankabalak,
pjuarezd and
reivaj05
bexsoft
reviewed
Sep 15, 2022
bexsoft
previously approved these changes
Sep 15, 2022
Collaborator
bexsoft
left a comment
bexsoft
left a comment
There was a problem hiding this comment.
LGTM, we need to rethink errors system
harshavardhana
previously requested changes
Sep 15, 2022
dilverse
reviewed
Sep 15, 2022
Signed-off-by: Daniel Valdivia <[email protected]>
Signed-off-by: Daniel Valdivia <[email protected]>
Signed-off-by: Daniel Valdivia <[email protected]>
dvaldivia
force-pushed
the
return-401-bad-login
branch
from
56e4cd2 to
5830d21
Compare
Signed-off-by: Daniel Valdivia <[email protected]>
bexsoft
approved these changes
Sep 15, 2022
dilverse
approved these changes
Sep 15, 2022
Alevsk
suggested changes
Sep 15, 2022
Contributor
Alevsk
left a comment
Alevsk
left a comment
There was a problem hiding this comment.
We need to rethink this because currently, im not sure if the error code would be 401 for this particular case, minio is not even reachable
Alevsk
approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Valdivia [email protected]