Don't show Bucket Name input error until field is touched #2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaankabalak
requested review from
Alevsk,
bexsoft,
cniackz,
dvaldivia,
jinapurapu,
prakashsvmx and
reivaj05
Contributor
Author
|
The permission test failures don't seem to be related with the changes in this PR |
dvaldivia
approved these changes
Sep 15, 2022
dvaldivia
previously approved these changes
Sep 15, 2022
jinapurapu
previously approved these changes
Sep 15, 2022
bexsoft
requested changes
Sep 15, 2022
Collaborator
bexsoft
left a comment
bexsoft
left a comment
There was a problem hiding this comment.
Please reset isDirty after bucket creation or exiting creation page
Contributor
Author
Good catch @bexsoft, I will work on this 👍 |
kaankabalak
dismissed stale reviews from jinapurapu and dvaldivia
via
8d8cd25
kaankabalak
force-pushed
the
add-bucket-error
branch
from
0eb1bbf to
8d8cd25
Compare
kaankabalak
force-pushed
the
add-bucket-error
branch
3 times, most recently
from
f1c4ae4 to
d33b44a
Compare
kaankabalak
force-pushed
the
add-bucket-error
branch
from
d33b44a to
10a31e1
Compare
Contributor
Author
|
I have applied the feedback given by @bexsoft, would appreciate it if you could take another look. Thanks in advance 👍 |
jinapurapu
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2315