do not log random errors using Go logger #2355
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harshavardhana
requested review from
Alevsk,
bexsoft,
dvaldivia and
prakashsvmx
Member
|
@harshavardhana some lint errors .PTAL |
we need to make sure that we print in consistent format for the logs, remove the unnecessary logs everywhere used via `log.Print*`
harshavardhana
force-pushed
the
do-not-log
branch
from
2ac7a82 to
bf5a2a1
Compare
Member
Author
fixed @prakashsvmx |
prakashsvmx
approved these changes
Oct 4, 2022
reivaj05
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we need to make sure that we print in consistent
format for the logs, remove the unnecessary logs
everywhere used via
log.Print*