Skip to content

Conversation

@cniackz
Copy link
Collaborator

@cniackz cniackz commented Oct 6, 2022

Objective:

To make Operator UI Tests run faster and more reliable.

Story:

Currently, there are two main tests:

  1. login.ts
  2. tenants.ts

They depend on different libraries, which is ok, not the main point to change here.
But I am going to group them in different folders, letting main uitls.ts be on top of them in case other tests are added in the future.

Additional Information:

This is going to make it just a bit faster. What is actually consuming lot of time here is the setup of the cluster with Operator and Tenant; not testcafe itself. But this is just the first PR. In my next PR, I will focus on the k8s side to see if we can actually decrease the time we consume in creating the cluster.

For reliability, I noticed that some marks render slower than the expected result, added some waits around them to let page to render prior checking on them, hopefully this will increase the reliability of our tests.

Re-org:

  • Isolating those tests that are more prone to failure when running together with other tests.

Screen Shot 2022-10-07 at 12 07 13 PM

Results:

Screen Shot 2022-10-07 at 2 03 55 PM

@cniackz cniackz added the WIP This PR is WIP and cannot be merged yet label Oct 6, 2022
@cniackz cniackz self-assigned this Oct 6, 2022
@cniackz cniackz force-pushed the operator-ui-tests-to-run-better-and-faster branch 2 times, most recently from 8f1af92 to 0270bad Compare October 6, 2022 16:34
@cniackz cniackz changed the title [WIP] - Splitting tests for faster execution Splitting Operator UI Tests for faster execution Oct 6, 2022
@cniackz cniackz requested a review from dvaldivia October 6, 2022 16:35
@cniackz cniackz added enhancement New feature or request and removed WIP This PR is WIP and cannot be merged yet labels Oct 6, 2022
@cniackz cniackz force-pushed the operator-ui-tests-to-run-better-and-faster branch from 0270bad to 3c5ddce Compare October 6, 2022 19:24
@cniackz cniackz changed the title Splitting Operator UI Tests for faster execution [WIP] - Splitting Operator UI Tests for faster execution Oct 6, 2022
@cniackz cniackz added the WIP This PR is WIP and cannot be merged yet label Oct 6, 2022
@cniackz cniackz force-pushed the operator-ui-tests-to-run-better-and-faster branch 9 times, most recently from fe7f2ff to 46e0342 Compare October 7, 2022 17:07
@cniackz cniackz force-pushed the operator-ui-tests-to-run-better-and-faster branch from 46e0342 to f23e39c Compare October 7, 2022 17:40
@cniackz cniackz changed the title [WIP] - Splitting Operator UI Tests for faster execution Splitting Operator UI Tests for faster execution Oct 7, 2022
@cniackz cniackz removed the WIP This PR is WIP and cannot be merged yet label Oct 7, 2022
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bexsoft bexsoft merged commit 43db772 into minio:master Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants