Fixed Users tab permissions to hide if CreateUser only User permission #2426
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 2, 2022 12:15
… is the only User permission
jinapurapu
requested review from
Alevsk,
adfost,
bexsoft,
cniackz,
dvaldivia,
kaankabalak,
pjuarezd,
prakashsvmx and
reivaj05
reivaj05
approved these changes
Nov 2, 2022
kaankabalak
approved these changes
Nov 3, 2022
bexsoft
approved these changes
Nov 3, 2022
adfost
pushed a commit
to adfost/console
that referenced
this pull request
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The admin:CreateUser permission is being granted to all Users, which is enabling the Users tab in the menu even if the logged in User does not actually have the permissions to view or change anything on the Users screen, leading them to an unusable screen. It now requires an additional User permission to display the Users tab.
Users tab is displayed for this policy
{
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Action": [
"admin:GetUser",
"admin:ListUsers"
],
"Resource": [
"arn:aws:s3:::*"
]
}
]
}
Users tab is not displayed for this policy:
{
"Version": "2012-10-17",
"Statement": [
{
"Effect": "Allow",
"Action": [
"s3:GetBucketLocation",
"s3:GetObject"
],
"Resource": [
"arn:aws:s3:::*"
]
}
]
}