Skip to content

Release v0.21.2 #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2022
Merged

Release v0.21.2 #2435

merged 1 commit into from
Nov 8, 2022

Conversation

@dvaldivia
Copy link
Collaborator

@dvaldivia dvaldivia commented Nov 7, 2022

Signed-off-by: Daniel Valdivia [email protected]

@dvaldivia dvaldivia self-assigned this Nov 7, 2022
bexsoft
bexsoft requested changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets wait until #2428 gets merged

bexsoft
bexsoft previously approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, will send this change right away, menu changes will be available in an upcoming release

reivaj05
reivaj05 previously approved these changes Nov 7, 2022
View reviewed changes
@harshavardhana
Copy link
Member

harshavardhana commented Nov 7, 2022 •
edited
Loading

The inspect tests are not passing

=== CONT  TestInspect
    inspect_test.go:100: 
        	Error Trace:	/home/runner/work/console/console/integration/inspect_test.go:100
        	Error:      	Not equal: 
        	            	expected: 500
        	            	actual  : 200
        	Test:       	TestInspect
=== RUN   TestInspect/Test_Empty_Path
--- FAIL: TestInspect (0.04s)
    --- PASS: TestInspect/Test_Invalid_Path (0.01s)
    --- PASS: TestInspect/Test_Invalid_characters_in_Path (0.01s)
    --- PASS: TestInspect/Test_valid_bucket (0.01s)
    --- PASS: TestInspect/Test_Empty_Path (0.01s)

Looks like the test must be reverted to use "200" OK not 500 as expected error @dvaldivia

@dvaldivia dvaldivia dismissed stale reviews from reivaj05 and bexsoft via 6569941 November 7, 2022 22:16
@dvaldivia
Release v0.21.2
a7c2c1b 
Signed-off-by: Daniel Valdivia <[email protected]>
bexsoft
bexsoft approved these changes Nov 7, 2022
View reviewed changes
Copy link
Collaborator

@bexsoft bexsoft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshavardhana harshavardhana merged commit 8a9fbb4 into minio:master Nov 8, 2022
@harshavardhana harshavardhana deleted the release-v0.21.2 branch November 8, 2022 05:03
reivaj05 pushed a commit to reivaj05/console that referenced this pull request Nov 8, 2022
@dvaldivia @reivaj05
Release v0.21.2 (minio#2435)
e71d72f 
Signed-off-by: Daniel Valdivia
<[email protected]>
adfost pushed a commit to adfost/console that referenced this pull request Nov 18, 2022
@dvaldivia @adfost
Release v0.21.2 (minio#2435)
e279464 
Signed-off-by: Daniel Valdivia
<[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harshavardhana harshavardhana harshavardhana approved these changes

@bexsoft bexsoft bexsoft approved these changes

@pjuarezd pjuarezd Awaiting requested review from pjuarezd

@cniackz cniackz Awaiting requested review from cniackz

@prakashsvmx prakashsvmx Awaiting requested review from prakashsvmx

@kaankabalak kaankabalak Awaiting requested review from kaankabalak

@jinapurapu jinapurapu Awaiting requested review from jinapurapu

@dilverse dilverse Awaiting requested review from dilverse

@reivaj05 reivaj05 Awaiting requested review from reivaj05

Assignees

@dvaldivia dvaldivia

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dvaldivia @harshavardhana @reivaj05 @bexsoft