Initial Changes to Login page styles #2467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Included new Inter font to console - Included new base styles to console (preparation for dark mode) Signed-off-by: Benjamin Perez <[email protected]>
bexsoft
requested review from
Alevsk,
cniackz,
dvaldivia,
jinapurapu,
kaankabalak,
kannappanr,
pjuarezd,
prakashsvmx and
reivaj05
dvaldivia
approved these changes
Nov 18, 2022
prakashsvmx
approved these changes
Nov 18, 2022
Member
prakashsvmx
left a comment
prakashsvmx
left a comment
There was a problem hiding this comment.
LGTM 👍
@bexsoft @dvaldivia would this block releases until the Multiple IDP is integrated?
Member
|
@bexsoft the png could be compressed as it is too large 2MB+ |
Collaborator
Author
No, Multiple IDP are still in design stage so right now no issues with it |
reivaj05
approved these changes
Nov 18, 2022
Collaborator
Author
Sure, Will make this change on mds |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
NOTE: IDP List names changes & Multiple IDP methods are not yet implemented in this PR
How does it look?
Signed-off-by: Benjamin Perez [email protected]