Add support for Remote Buckets and Replication #262
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Don't merge this as-is, keep in a branch such that we can decide on the input parameters later on to avoid this clobbering up the releases. Since we need to comprehensively add
|
bexsoft
requested changes
Aug 31, 2020
Collaborator
bexsoft
left a comment
bexsoft
left a comment
There was a problem hiding this comment.
Please fix
restapi/admin_remote_buckets.go:27:6: `registerAdminBucketRemoteHandlers` is unused (deadcode)
func registerAdminBucketRemoteHandlers(api *operations.ConsoleAPI) {
^
restapi/admin_remote_buckets.go:39:6: func `getRemoteBucketsResponse` is unused (unused)
added 2 commits
August 31, 2020 18:32
bexsoft
reviewed
Aug 31, 2020
dvaldivia
force-pushed
the
remote-buckets
branch
from
6035607 to
b28529c
Compare
…into remote-buckets-dvaldivia
…into remote-buckets-dvaldivia
…into remote-buckets-dvaldivia
…into remote-buckets-dvaldivia
# Conflicts: # go.mod # go.sum # portal-ui/bindata_assetfs.go # portal-ui/src/screens/Console/Buckets/ViewBucket/ViewBucket.tsx # portal-ui/src/screens/Console/Common/FormComponents/SelectWrapper/SelectWrapper.tsx # restapi/embedded_spec.go # restapi/operations/console_api.go # restapi/user_buckets.go # swagger.yml
Collaborator
|
Replaced by #287 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #261