Replace resources api to return the max allocatable memory #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bexsoft
reviewed
Sep 2, 2020
| tags: | ||
| - AdminAPI | ||
|
|
||
| /cluster/resources: |
Collaborator
There was a problem hiding this comment.
Is this is no longer needed?
Collaborator
Author
There was a problem hiding this comment.
not anymore, this was meant to be for the same feature of calculating the max ram but we'll do it in this new api
Collaborator
There was a problem hiding this comment.
I think resources could also express storage capacity if available right? I think nesting this API under resources made sense
Collaborator
Author
There was a problem hiding this comment.
that api is no longer needed, was designed for the main purpose
Alevsk
previously approved these changes
Sep 2, 2020
cesnietor
force-pushed
the
max-mem-api
branch
from
1783b39 to
375b7f3
Compare
Collaborator
Author
|
PR modified to use queryparameter instead of body parameter |
dvaldivia
approved these changes
Sep 2, 2020
Alevsk
approved these changes
Sep 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resouces api changed to GET on
/api/v1/cluster/max-allocatable-memorywhich returns the max allocatable memory for a given number of nodes,
nodes with taints NoExecute or NoSchedule shall not be considered.
request needs to be e.g.
Response payload:
If not enough nodes or no available memory response will be empty
{}